Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to silence OutputDebugString output #88

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Add an option to silence OutputDebugString output #88

merged 2 commits into from
Dec 9, 2023

Conversation

aitap
Copy link
Contributor

@aitap aitap commented Dec 8, 2023

Hi! I would like to use catchsegv to debug crashes during automatic checks of R packages on Windows.

Some applications used by R during the check (MSYS compilers, MiKTeX) output a lot of distracting information via OutputDebugString(), so I added a flag to the debugger options and to catchsegv to silence it.

Please let me know if my changes need to be improved before they can be merged.

@aitap
debugOptions.no_debug_string and catchsegv flag
76ecf9d 
Some applications (MSYS compilers, MiKTeX) output a lot of distracting
information via OutputDebugString(). Add a flag to catchsegv to silence
it.
@jrfonseca
Copy link
Owner

Makes sense. I primarily use catchsegv to debug components which log messages through OutputDebugString, hence the current behavior, but I can see how that would only get in the way for components which log to stderr.

If you could update https://github.com/jrfonseca/drmingw/blob/master/README.md#catchsegv too, it would be perfect.

Thanks.

@aitap
Copy link
Contributor Author

aitap commented Dec 8, 2023

Thanks for the quick reply! I've edited README.md and reworded the option description to avoid repetition.

@jrfonseca
Copy link
Owner

There are some issues with the build, unrelated to this change. (I suspect some upstream CMake change broke something.) I want to sort those out before merging this.

@jrfonseca jrfonseca merged commit c0e5849 into jrfonseca:master Dec 9, 2023
3 of 5 checks passed
@aitap
Copy link
Contributor Author

aitap commented Jan 16, 2024

Many thanks for merging this pull request! I was hoping to show off catchsegv at work on the big auto-check machine, but that will take more diplomacy and effort. My colleagues and me are using catchsegv locally and are very grateful for its existence.

@aitap aitap deleted the silence_OutputDebugString branch January 16, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitap @jrfonseca